Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-24187 Fix code style issues in SystemDistributedConfigurationPropertyHolder #5027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

IGNITE-24187 Fix code style issues in SystemDistributedConfigurationPropertyHolder #5027

wants to merge 1 commit into from
+8 −9

Conversation

kgusakov
Copy link
Contributor

@kgusakov kgusakov commented Jan 12, 2025 •
edited
Loading

tkalkirill
tkalkirill reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@tkalkirill tkalkirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket description states what will be done:

CompletableFuture.completedFuture(null) must be replace nullCompletedFuture

I didn't see these changes.

@kgusakov
Copy link
Contributor Author

The ticket description states what will be done:

CompletableFuture.completedFuture(null) must be replace nullCompletedFuture

I didn't see these changes.

Ticket description was fixed. Still think that the additional dependency from the core module creates more potential issues in future, than fixes now.

tkalkirill
tkalkirill reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@tkalkirill tkalkirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket description was fixed. Still think that the additional dependency from the core module creates more potential issues in future, than fixes now.

Please describe what potential issues there might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkalkirill tkalkirill tkalkirill left review comments

@ibessonov ibessonov ibessonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgusakov @tkalkirill @ibessonov