Reduce coordinator logs (#17566)

apache · Dec 16, 2024 · 0335bdd · 0335bdd
1 parent 29ab12c
commit 0335bdd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 16 deletions.
diff --git a/...rc/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java b/...rc/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java
@@ -491,10 +491,9 @@ static List<Interval> filterSkipIntervals(Interval totalInterval, List<Interval>
         remainingStart = skipInterval.getEnd();
       } else {
         // Ignore this skipInterval
-        log.warn(
+        log.debug(
             "skipInterval[%s] is not contained in remainingInterval[%s]",
-            skipInterval,
-            new Interval(remainingStart, remainingEnd)
+            skipInterval, new Interval(remainingStart, remainingEnd)
         );
       }
     }

diff --git a/server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java b/server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java
@@ -76,14 +76,10 @@
 public class HttpLoadQueuePeon implements LoadQueuePeon
 {
   public static final TypeReference<List<DataSegmentChangeRequest>> REQUEST_ENTITY_TYPE_REF =
-      new TypeReference<List<DataSegmentChangeRequest>>()
-      {
-      };
+      new TypeReference<>() {};
 
   public static final TypeReference<List<DataSegmentChangeResponse>> RESPONSE_ENTITY_TYPE_REF =
-      new TypeReference<List<DataSegmentChangeResponse>>()
-      {
-      };
+      new TypeReference<>() {};
 
   private static final EmittingLogger log = new EmittingLogger(HttpLoadQueuePeon.class);
 
@@ -389,9 +385,10 @@ public void stop()
       log.info("Stopping load queue peon for server[%s].", serverId);
       stopped = true;
 
-      // Cancel all queued requests
-      queuedSegments.forEach(holder -> onRequestCompleted(holder, RequestStatus.CANCELLED));
-      log.info("Cancelled [%d] requests queued on server [%s].", queuedSegments.size(), serverId);
+      if (!queuedSegments.isEmpty()) {
+        queuedSegments.forEach(holder -> onRequestCompleted(holder, RequestStatus.CANCELLED));
+        log.info("Cancelled [%d] requests queued on server[%s].", queuedSegments.size(), serverId);
+      }
 
       segmentsToDrop.clear();
       segmentsToLoad.clear();

diff --git a/server/src/test/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeonTest.java b/server/src/test/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeonTest.java
@@ -19,7 +19,6 @@
 
 package org.apache.druid.server.coordinator.loading;
 
-import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -350,9 +349,8 @@ public <Intermediate, Final> ListenableFuture<Final> go(
       httpResponseHandler.handleResponse(httpResponse, null);
       try {
         List<DataSegmentChangeRequest> changeRequests = MAPPER.readValue(
-            request.getContent().array(), new TypeReference<List<DataSegmentChangeRequest>>()
-            {
-            }
+            request.getContent().array(),
+            HttpLoadQueuePeon.REQUEST_ENTITY_TYPE_REF
         );
 
         List<DataSegmentChangeResponse> statuses = new ArrayList<>(changeRequests.size());