-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](metrics) Correct statistical method for file cache stats #47020
base: master
Are you sure you want to change the base?
[fix](metrics) Correct statistical method for file cache stats #47020
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
2ed30df
to
2d905e2
Compare
run buildall |
TPC-H: Total hot run time: 33064 ms
|
TPC-DS: Total hot run time: 190252 ms
|
ClickBench: Total hot run time: 31.67 s
|
TeamCity be ut coverage result: |
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Problem Summary:
Current file cache statistics in not calculate in right way. It calculate reading bytes num by accumulate reading bytes in current io context repeadly rather than accumulate by increment. Correct this behavior in this PR.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)