[CALCITE-6744] Returns null when the column origin contains the corre… #4145
+48
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suibianwanwank
commented
Jan 14, 2025
| if (inputSet != null) { | ||
| set.addAll(inputSet); | ||
| if (inputSet == null) { | ||
| return null; |
There was a problem hiding this comment.
The logic here doesn't seem to fit the documentation.
set of origin columns, or null if this information cannot be determined (whereas empty set indicates definitely no origin columns at all)
There was a problem hiding this comment.
where is the documentation you are mentioning?
mihaibudiu
reviewed
Jan 15, 2025
| if (inputSet != null) { | ||
| set.addAll(inputSet); | ||
| if (inputSet == null) { | ||
| return null; |
There was a problem hiding this comment.
where is the documentation you are mentioning?
| @@ -303,8 +306,16 @@ private static Set<RelColumnOrigin> getMultipleColumns(RexNode rexNode, RelNode | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| @Override public Void visitFieldAccess(RexFieldAccess fieldAccess) { | |||
There was a problem hiding this comment.
why does this indicate an access in a correlated variable?
could this be an access into a field with type ROW?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lation variable