Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6764] Field access from a nullable ROW should be nullable (part 2) #4139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CALCITE-6764] Field access from a nullable ROW should be nullable (part 2) #4139

wants to merge 3 commits into from
+173 −27

Conversation

mihaibudiu
Copy link
Contributor

We have already merged a PR fixing this issue, but I have reopened it, and this is a second PR addressing a second bug related to the same problem.

@mihaibudiu mihaibudiu mentioned this pull request Jan 12, 2025
Draft
asolimando
asolimando reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@asolimando asolimando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major but I am confused on a couple of points @mihaibudiu, can you take a look?

core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java Outdated Show resolved Hide resolved
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java Show resolved Hide resolved
core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java Outdated Show resolved Hide resolved
core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java Show resolved Hide resolved
@mihaibudiu
Copy link
Contributor Author

@asolimando I have pushed a commit which hopefully addresses your comments.

@mihaibudiu
Copy link
Contributor Author

I will write a few more tests, so I will mark this PR as draft until I am sure it passes all of them. Hopefully this won't take too long.

@mihaibudiu mihaibudiu marked this pull request as draft January 14, 2025 01:10
@asolimando
Copy link
Member

@asolimando I have pushed a commit which hopefully addresses your comments.

Thanks @mihaibudiu, LGTM, just proposed two improved test names, the rest is good, feel free to ping me for an extra review round once the extra tests are ready, if needed

@mihaibudiu mihaibudiu marked this pull request as ready for review January 15, 2025 02:12
@mihaibudiu
Copy link
Contributor Author

The complete fix required some additions to the type factory interfaces and making a method public.
As I commented in the jira https://issues.apache.org/jira/browse/CALCITE-6764, I think that the methods from the type factory to create nullable types are broken for record types.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.7% Coverage on New Code
17.9% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolimando asolimando asolimando left review comments

@julianhyde julianhyde julianhyde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaibudiu @asolimando @julianhyde