Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run ESLint in workflow #246

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Conversation

mroderick
Copy link
Contributor

This will help catch any errors before mergin them into the default branch

This will help catch any errors before mergin them into the default branch
@animir
Copy link
Owner

animir commented Dec 24, 2023

Hi @mroderick npm ci command throws an error. It requires package-lock.json, which doesn't exist in this repo. You can see more in the Gihub workflow Details.

@mroderick
Copy link
Contributor Author

Hi @mroderick npm ci command throws an error. It requires package-lock.json, which doesn't exist in this repo. You can see more in the Gihub workflow Details.

Yeah, that's pretty uncommon these days. I've added another commit, so the workflow uses npm install instead of npm ci.

@animir animir merged commit 10e4a79 into animir:master Dec 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants