refactor: change json-rpc trait names, relax bounds #1921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the RPC trait system more clear and flexible, provide non-owned options requirements baked into the traits
Solution
RpcParam
toRpcSend
andRpcReturn
toRpcReceive
to make them clearerRpcReturn
andRpcObject
to allow borrowing from deserializersRpcObject
to eitherRpcBorrow
orRpcSend
, e.g. inResponsePayload::serialize_payload
we can relax toRpcSend
Note
The implementation of
RpcRecv
is still more strict thanDeserializeOwned
, as it requires+ 'static
rather thanfor<'de> Deserialize<'de>
. This means that it is not iplemented on (e.g.) things that borrow from some non-deserializer context or environment during deserialization. Some parts of our future and streaming systems rely on this, and it seems like just marginal benefit to changePR Checklist