refactor: make RpcCall an IntoFuture #1860
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
DaniPopes
force-pushed
the
dani/rpc-call-async-fn
branch
from
16ffd80 to
da992b4
Compare
DaniPopes
force-pushed
the
dani/rpc-call-async-fn
branch
from
da992b4 to
1070c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement RpcCall as an async fn, meaning it becomes IntoFuture. The current implementation is a manually unrolled async fn state machine, but there is no reason for this to be the case.
TODO: needs either "impl trait in assoc types" or to fix the "'a is unconstrained" error