Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing choosing the insert order when creating a new entry. You can… #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmerckx
Copy link
Contributor

@dmerckx dmerckx commented Jan 16, 2025

… override this setting in the parent channel

… override this setting in the parent channel
@dmerckx dmerckx requested a review from benmerckx January 16, 2025 16:09
@@ -133,6 +139,8 @@ function NewEntryForm({parentId}: NewEntryProps) {
}

const typeField = useMemo(() => {
console.log('Config', config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup needed :)

@@ -160,6 +163,9 @@ export interface TypeConfig<Definition> {
/** A React component used to view a thumbnail of this type in the dashboard */
summaryThumb?: View<SummaryProps>

/** The position where new children will be inserted */
insertOrder?: 'top' | 'bottom' | 'free'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for 'first' | 'last' ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants