fix(connectors): don't expose duplicates of canRefine #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c176f8:
|
Haroenv
force-pushed
the
next
branch
2 times, most recently
from
7ff6737 to
b37ba30
Compare
Haroenv
force-pushed
the
fix/connectors-canrefine
branch
from
eb71d75 to
84b17ba
Compare
In the past, `canRefine` has been introduced as a consistent way to check if any widget can be refined. There were previous largely overlapping pieces of information exposed which were deprecated. These are now removed. [FX-3195] BREAKING CHANGE: clearRefinements: replace `hasRefinements` with `canRefine` BREAKING CHANGE: hitsPerPage: replace `hasNoResults` with `!canRefine` BREAKING CHANGE: numericMenu: replace `hasNoResults` with `!canRefine` BREAKING CHANGE: ratingMenu: replace `hasNoResults` with `!canRefine` BREAKING CHANGE: sortBy: replace `hasNoResults` with `!canRefine`
Haroenv
force-pushed
the
fix/connectors-canrefine
branch
from
84b17ba to
6c176f8
Compare
Haroenv
requested review from
aymeric-giraudet
and removed request for
sarahdayan
aymeric-giraudet
approved these changes
Dec 30, 2024
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
In the past, `canRefine` has been introduced as a consistent way to check if any widget can be refined. There were previous largely overlapping pieces of information exposed which were deprecated. These are now removed. [FX-3195] BREAKING CHANGE: clearRefinements: replace `hasRefinements` with `canRefine` BREAKING CHANGE: hitsPerPage: replace `hasNoResults` with `!canRefine` BREAKING CHANGE: numericMenu: replace `hasNoResults` with `!canRefine` BREAKING CHANGE: ratingMenu: replace `hasNoResults` with `!canRefine` BREAKING CHANGE: sortBy: replace `hasNoResults` with `!canRefine`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past,
canRefinehas been introduced as a consistent way to check if any widget can be refined. There were previous largely overlapping pieces of information exposed which were deprecated. These are now removed.FX-3195
BREAKING CHANGE: clearRefinements: replace
hasRefinementswithcanRefineBREAKING CHANGE: hitsPerPage: replace
hasNoResultswith!canRefineBREAKING CHANGE: numericMenu: replace
hasNoResultswith!canRefineBREAKING CHANGE: ratingMenu: replace
hasNoResultswith!canRefineBREAKING CHANGE: sortBy: replace
hasNoResultswith!canRefine