fix evaluate

aiaccel/cli/start.py

@@ -124,8 +124,8 @@ def main() -> None:  # pragma: no cover
     config_name = Path(args.config).name
     shutil.copy(Path(args.config), dst / config_name)
 
-    if os.path.exists(workspace.final_result_file):
-        with open(workspace.final_result_file, "r") as f:
+    if os.path.exists(workspace.best_result_file):
+        with open(workspace.best_result_file, "r") as f:
             final_results: list[dict[str, Any]] = yaml.load(f, Loader=yaml.UnsafeLoader)
 
         for i, final_result in enumerate(final_results):

aiaccel/scheduler/abstract_scheduler.py

@@ -289,11 +289,15 @@ def evaluate(self) -> None:
 
         best_trial_ids, _ = self.storage.get_best_trial(self.goals)
         if best_trial_ids is None:
-            self.logger.error(f"Failed to output {self.workspace.final_result_file}.")
+            self.logger.error(f"Failed to output {self.workspace.best_result_file}.")
             return
         hp_results = []
         for best_trial_id in best_trial_ids:
             hp_results.append(self.storage.get_hp_dict(best_trial_id))
-        create_yaml(self.workspace.final_result_file, hp_results, self.workspace.lock)
-        self.logger.info("Best hyperparameter is followings:")
-        self.logger.info(hp_results)
+
+        create_yaml(self.workspace.best_result_file, hp_results, self.workspace.lock)
+
+        finished = self.storage.get_num_finished()
+        if self.config.optimize.trial_number >= finished:
+            self.logger.info("Best hyperparameter is followings:")
+            self.logger.info(hp_results)

aiaccel/workspace.py

@@ -78,7 +78,6 @@ def __init__(self, base_path: str):
         self.storage = self.path / dict_storage
         self.tensorboard = self.path / dict_tensorboard
         self.timestamp = self.path / dict_timestamp
-
         self.consists = [
             self.alive,
             self.error,
@@ -103,6 +102,8 @@ def __init__(self, base_path: str):
         self.retults_csv_file = self.path / "results.csv"
         self.final_result_file = self.path / "final_result.result"
         self.storage_file_path = self.storage / "storage.db"
+        self.best_result_file = self.path / "best_result.yaml"
+
 
     def create(self) -> bool:
         """Create a work directory.

tests/integration/integration_test.py

@@ -94,6 +94,3 @@ def evaluate(self, config, is_multi_objective=False):
         assert finished == config.optimize.trial_number
         assert ready == 0
         assert running == 0
-
-        if not is_multi_objective:
-            assert workspace.final_result_file.exists()