Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deploy-related scripts #1328

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Improve deploy-related scripts #1328

merged 5 commits into from
Sep 13, 2024

Conversation

platfowner
Copy link
Member

@platfowner platfowner commented Sep 13, 2024 •
edited
Loading

Change summary:

  • Remove unnecessary -R option from chown and chmod
  • Add _gcp suffix to gcp ip address files
  • Update node param-related scripts for onprem hosting
  • Rename port number directory in blockchain data uploading

Related issues:

jiyoung-an
jiyoung-an approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@jiyoung-an jiyoung-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@platfowner
Copy link
Member Author

Thanks for the review! @jiyoung-an Now merging..

@platfowner platfowner merged commit 6e6ffdb into develop Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoung-an jiyoung-an jiyoung-an approved these changes

@shyun-comcom shyun-comcom Awaiting requested review from shyun-comcom

@minho-comcom-ai minho-comcom-ai Awaiting requested review from minho-comcom-ai

@yoojinko yoojinko Awaiting requested review from yoojinko

@akastercomcom akastercomcom Awaiting requested review from akastercomcom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platfowner @jiyoung-an