Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added folder for paper data reconstruction #25

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

csav3
Copy link

@csav3 csav3 commented Feb 3, 2021

No description provided.

@vc1492a
Copy link
Collaborator

vc1492a commented Feb 19, 2021

Thanks @csav3 for opening this PR! It looks like this helps with #20. Will take a look and circle back!

@vc1492a vc1492a self-requested a review February 19, 2021 16:38
@vc1492a vc1492a added documentation This issue related to documentation. enhancement and removed enhancement labels Feb 19, 2021
@vc1492a vc1492a changed the base branch from main to dev February 19, 2021 16:39
Copy link
Collaborator

@vc1492a vc1492a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csav3 looks pretty good! I made some commits locally which I will try to push to this PR related to removing hidden files and some other minor cleanup items. The data looks great, very clean and nice job on cleaning up the author names! It will be fun to dig into this more, creating examples from the data and writing some tests to ensure things are working as expected.

I think a good next step (if we haven't done it already) may be to use the data you collected to see if we come close to the descriptive and summary statistics that are provided about the dataset in the original paper. If we could do that prior to merging to the dev branch that would be great!

@vc1492a
Copy link
Collaborator

vc1492a commented Feb 19, 2021

@csav3 I couldn't push to your fork / branch specifically but checkout the changes I pushed to this repo's feature/paper_data branch. Could you please make the same changes to your fork and update this PR? Thanks. You should be able to pul those changes into your fork and do it all in one step.

@vc1492a vc1492a changed the title Added folder for paper data reconstruction [WIP] Added folder for paper data reconstruction Feb 19, 2021
@vc1492a vc1492a requested a review from adidier17 February 22, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants