Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): always use latest published version "TEST" #953

Closed
wants to merge 3 commits into from

Conversation

muhabdulkadir
Copy link
Contributor

@muhabdulkadir muhabdulkadir commented Dec 3, 2024

Closes #

Changes

  • resolve concert intra repo dependencies to always use latest npm published package

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@@ -64,9 +64,9 @@
"yargs": "17.7.2"
},
"dependencies": {
"@accordproject/concerto-cto": "file:../concerto-cto",
"@accordproject/concerto-cto": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want this? In the future when we release v4, and if some want to install [email protected], won't this forcefully install [email protected] and [email protected] which themselves could have a breaking change and thus breaking code for [email protected]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test.

@muhabdulkadir muhabdulkadir changed the title fix(package): always use latest published version fix(package): always use latest published version "TEST" Dec 3, 2024
@@ -0,0 +1,4 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've moved to npm workspaces I believe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use lerna anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants