-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): always use latest published version "TEST" #953
Conversation
Signed-off-by: muhammed-abdulkadir <[email protected]>
packages/concerto-core/package.json
Outdated
@@ -64,9 +64,9 @@ | |||
"yargs": "17.7.2" | |||
}, | |||
"dependencies": { | |||
"@accordproject/concerto-cto": "file:../concerto-cto", | |||
"@accordproject/concerto-cto": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want this? In the future when we release v4, and if some want to install [email protected]
, won't this forcefully install [email protected]
and [email protected]
which themselves could have a breaking change and thus breaking code for [email protected]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test.
@@ -0,0 +1,4 @@ | |||
{ | |||
"$schema": "node_modules/lerna/schemas/lerna-schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've moved to npm workspaces I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use lerna anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #
Changes
Author Checklist
--signoff
option of git commit.main
fromfork:branchname