Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concerto-core:Migrated to ESM from CommonJS Modules #832

Closed
wants to merge 1 commit into from

Conversation

subhajit20
Copy link
Contributor

@subhajit20 subhajit20 commented Mar 23, 2024

Closes #763

concerto-core:Migrated to ESM from CommonJS Modules

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@subhajit20
Copy link
Contributor Author

subhajit20 commented Mar 23, 2024

hey @mttrbrts @sanketshevkar I am making this changes pr to make sure weather I am going in the right direction .... is this the way how all the files will be changed and migrated into ESM from common?
Just need feedback.

@sanketshevkar sanketshevkar requested a review from mttrbrts March 28, 2024 05:46
@sanketshevkar
Copy link
Member

Hey @subhajit20
I'm a bit skeptical about this approach. It feels you might have mixed up the two syntax. You're importing using require but then exporting using export.

I believe you can find strategies over the net which other projects/teams might have used to port from CommonJS to ESM

@subhajit20
Copy link
Contributor Author

Hey @subhajit20 I'm a bit skeptical about this approach. It feels you might have mixed up the two syntax. You're importing using require but then exporting using export.

I believe you can find strategies over the net which other projects/teams might have used to port from CommonJS to ESM

Alright I got your point, I think I need to covert all the require to import

@dselman dselman closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to ESM from CommonJS Modules
3 participants