SMQ- 2546 - Add clients telemetry to journals service #2647
+526
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
smq2546-jornal
branch
from
7750fa4 to
c52b865
Compare
dborovcanin
requested changes
Jan 16, 2025
There was a problem hiding this comment.
It's OK to use Journal service as telemetry aggregator, but we should consider using some actual telemetry collectors for event processing. I.e. we can use journaling service as a final destination and apply access control and some processing to provide nice API, but what we need is an integration with telemetry collectors that will consume events, process them, store them, and provide search and filtering on them. Then, we need a background task to sync Journal service with them. Take a look at Elastic, Prometheus, InfluxDB.
| } | ||
|
|
||
| return nil | ||
| } |
|
|
||
| func (am *authorizationMiddleware) RetrieveClientTelemetry(ctx context.Context, clientID, domainID string) (journal.ClientsTelemetry, error) { | ||
| return am.svc.RetrieveClientTelemetry(ctx, clientID, domainID) | ||
| } |
| }(time.Now()) | ||
|
|
||
| return mm.service.RetrieveClientTelemetry(ctx, clientID, domainID) | ||
| } |
Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
force-pushed
the
smq2546-jornal
branch
from
c52b865 to
d166090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds clients telemetry to the journals service
What does this do?
This pr adds a means to monitor information about clients
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No,
Did you document any new/modified feature?
No
Notes