Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-2632 - Separate PAT logic in middleware #2636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nyagamunene
Copy link
Contributor

What type of PR is this?

This is a refactor because it seperates PATs logic from Authz middleware

What does this do?

It seperates PATs logic from Authz middleware for users and clients

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes

Did you document any new/modified feature?

No

Notes

@nyagamunene nyagamunene changed the title MG-2632 - Separate middleware for PAT logic MG-2632 - Separate PAT logic in middleware Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 488 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (153d230) to head (573c8e4).

Files with missing lines Patch % Lines
clients/middleware/pat.go 0.00% 360 Missing ⚠️
users/middleware/pat.go 0.00% 126 Missing ⚠️
auth/service.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2636      +/-   ##
==========================================
- Coverage   45.56%   39.30%   -6.26%     
==========================================
  Files         345      263      -82     
  Lines       44059    39073    -4986     
==========================================
- Hits        20075    15359    -4716     
- Misses      21799    22605     +806     
+ Partials     2185     1109    -1076     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin
Copy link
Collaborator

@arvindh123 Please review this one.

Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyagamunene Please resolve conflicts.

Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Separate middleware for PAT logics
2 participants