Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard states #993

Merged
merged 3 commits into from
Aug 2, 2022
Merged

fix: dashboard states #993

merged 3 commits into from
Aug 2, 2022

Conversation

defispartan
Copy link
Collaborator

@defispartan defispartan commented Aug 2, 2022

Addresses a few errors:

  • Table header showing in 'Assets To Supply' header when the market is frozen and there are no assets

AssetSupplyBug

  • Incorrectly displaying "Your wallet balance is empty" on production markets
  • On the reserve overview page, the frozen warning for harmony assets is missing a link to the snapshot vote

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.67 KB (🟡 +115 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 54.29 KB (🟡 +5 B) 543.96 KB
/reserve-overview 73.49 KB (🟢 -17 B) 563.16 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

@defispartan defispartan merged commit f251194 into main Aug 2, 2022
@defispartan defispartan deleted the fix/dashboard-states branch August 2, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supply asset list header bug Dashboard shows empty wallet warning when it shouldn't
3 participants