Improve block detection #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal Block code. No behavioral change yet.
improve, particularly around dead-ends
…e block, not the entire road
dabreegster
commented
Apr 5, 2024
| (road.src_i, road.dst_i) | ||
| } | ||
| }; | ||
| let mut current_intersection = start_intersection; |
There was a problem hiding this comment.
I feel like all of this logic ought to be simpler if we trace tuples (road, left / right, forwards / backwards). I might try that in a future PR.
|
|
||
| // TODO Use RoadEdge? | ||
| // This skips the "interior" piece of any loop roads | ||
| pub fn get_road_sides_sorted(&self, streets: &StreetNetwork) -> Vec<RoadSideID> { |
There was a problem hiding this comment.
This would be quite nice to explore in a smaller unit test, because I've found it confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more steps towards #248. Individual blocks involving dead-end roads now mostly work, thanks to bringing in code from https://github.com/a-b-street/abstreet/blob/main/blockfinding/src/lib.rs. (Why solve problems twice?)
And then improve block classification by looking only at the lane closest to the block, not the whole road. Many cases improve.
I looked at loads of before/afters through this, but didn't take any screenshots this time.