Handle diagonal and perpendicular parking #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Apr 1, 2024
| traffic_direction: Direction, | ||
| ) -> (LaneType, Direction, EnumSet<TurnDirection>) { | ||
| let parking_type = match p.orientation { | ||
| Some(ParkingOrientation::Parallel) | None => ParkingType::Parallel, |
There was a problem hiding this comment.
Assuming parallel when it's not tagged
| @@ -571,7 +583,8 @@ impl MapConfig { | |||
| country_code: String::new(), | |||
| bikes_can_use_bus_lanes: true, | |||
| inferred_sidewalks: false, | |||
| street_parking_spot_length: Distance::meters(8.0), | |||
| parallel_street_parking_spot_length: Distance::meters(8.0), | |||
| vehicle_width_for_parking_spots: Distance::meters(3.0), | |||
There was a problem hiding this comment.
Just making something up that looks vaguely reasonable. All of this config needs to later turn into region-dependant values
| @@ -269,6 +286,78 @@ fn draw_parking_lines(lane: &LaneSpec, center: &PolyLine, streets: &StreetNetwor | |||
| result | |||
| } | |||
|
|
|||
| fn draw_diagonal_parking_lines( | |||
There was a problem hiding this comment.
The markings for the two new cases could be improved to look better, and this code is quite messy. Just getting something started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @ginnyTheCat for fixing some parsing bugs in Muv
Here's how perpendicular spots at https://strassenraumkarte.osm-berlin.org/?map=micromap#19/52.47214/13.43922 look:
And diagonals at https://strassenraumkarte.osm-berlin.org/?map=micromap#19/52.47450/13.42235:
#252 tracks further work to handle separately mapped parking areas