Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UX-1370): avatar badge alignment #243

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix(UX-1370): avatar badge alignment #243

wants to merge 7 commits into from
+8 −6

Conversation

thelukewalton
Copy link
Collaborator

No description provided.

@thelukewalton thelukewalton requested a review from a team as a code owner January 16, 2025 16:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • ✅ - Branch is not behind
  • 📈 - Code coverage: 52.45% (🔻 down from 52.46%)
    See details
    File Name%Passing?
    lib/src/components/accordion/accordion.dart100%✅
    lib/src/utils/rounded.dart100%✅
    lib/src/components/avatar_rail/avatar_rail.dart53.7%⛔️
    lib/src/components/avatars/avatar.dart94%✅
    lib/src/components/badges/indicator.dart100%✅
    lib/src/components/badges/label.dart100%✅
    lib/src/components/badges/priority_pill.dart100%✅
    lib/src/components/badges/status_label.dart100%✅
    lib/src/components/badges/tag.dart98.5%✅
    lib/src/components/bottom sheets/bottom_sheet.dart0%⛔️
    lib/src/components/bottom sheets/menu_items.dart0%⛔️
    lib/src/components/breadcrumb/breadcrumb.dart86.2%✅
    lib/src/components/button_group/button_group.dart0%⛔️
    lib/src/components/buttons/button.dart97.7%✅
    lib/src/components/buttons/button_style.dart100%✅
    lib/src/components/buttons/icon_button.dart51.2%⛔️
    lib/src/components/buttons/input_icon_button.dart72.7%⛔️
    lib/src/components/chat_item/chat_item.dart98.6%✅
    lib/src/components/chat_item/contact_item.dart0%⛔️
    lib/src/components/checkbox/checkbox.dart100%✅
    lib/src/components/chips/assist_chip.dart0%⛔️
    lib/src/components/chips/chip.dart81.6%✅
    lib/src/components/chips/filter_chip.dart0%⛔️
    lib/src/components/chips/input_chip.dart0%⛔️
    lib/src/components/chips/status_chip.dart90.9%✅
    lib/src/components/comms_button/comms_button.dart82%✅
    lib/src/components/date_input/date_input.dart0%⛔️
    lib/src/components/dial_pad/dial_pad.dart100%✅
    lib/src/components/dialog/dialog.dart0%⛔️
    lib/src/components/dropdown/dropdown.dart0%⛔️
    lib/src/components/fabs/fab.dart100%✅
    lib/src/components/filter_selection/filter_selection.dart0%⛔️
    lib/src/components/global_header/global_header.dart0%⛔️
    lib/src/components/global_header/header_tab_item.dart0%⛔️
    lib/src/components/icon/icon.dart100%✅
    lib/src/components/in_page_banner/in_page_banner.dart100%✅
    lib/src/components/list_item/dropdown_list_item.dart0%⛔️
    lib/src/components/list_item/list_item.dart0%⛔️
    lib/src/components/list_item/notification_list_item.dart0%⛔️
    lib/src/components/navigation bar/navigation_bar.dart94.5%✅
    lib/src/components/navigation_rail/navigation_rail.dart0%⛔️
    lib/src/components/pagination/pagination.dart0.6%⛔️
    lib/src/components/password/password_input.dart100%✅
    lib/src/components/phone_input/phone_input.dart0%⛔️
    lib/src/components/progress/progress_bar.dart0%⛔️
    lib/src/components/progress/progress_circle.dart0%⛔️
    lib/src/components/radio/radio.dart0%⛔️
    lib/src/components/range_selector/range_selector.dart84.5%✅
    lib/src/components/screen_header_bar/screen_header_bar.dart0%⛔️
    lib/src/components/search_bar/search_bar.dart98.1%✅
    lib/src/components/segmented_control/segmented_control.dart0%⛔️
    lib/src/components/select_input/select_input.dart0%⛔️
    lib/src/components/slider/slider.dart82.3%✅
    lib/src/components/snack_bar/snack_bar.dart0%⛔️
    lib/src/components/stepper/stepper.dart95.1%✅
    lib/src/components/stepper_input/stepper_input.dart71.9%⛔️
    lib/src/components/switch/zeta_switch.dart0%⛔️
    lib/src/components/system_banner/system_banner.dart85.4%✅
    lib/src/components/tabs/tab.dart0%⛔️
    lib/src/components/tabs/tab_bar.dart0%⛔️
    lib/src/components/text_input/text_input.dart0%⛔️
    lib/src/components/time_input/time_input.dart0%⛔️
    lib/src/components/tooltip/tooltip.dart98.9%✅
    lib/src/components/top_app_bar/top_app_bar.dart86%✅
    lib/src/components/text_input/internal_text_input.dart72.5%⛔️
    lib/src/interfaces/form_field.dart81.4%✅
    lib/src/components/list_item/list_scope.dart0%⛔️
    lib/src/interfaces/phone_number.dart0%⛔️
    lib/src/components/progress/progress.dart0%⛔️
    lib/src/components/switch/material_switch.dart0%⛔️
    lib/src/components/text_input/hint_text.dart77.8%⛔️
    lib/src/components/text_input/input_label.dart0%⛔️
    lib/src/components/top_app_bar/extended_top_app_bar.dart93.9%✅
    lib/src/components/top_app_bar/search_top_app_bar.dart86.5%✅
    lib/src/generated/tokens/primitives.g.dart67.6%⛔️
    lib/src/generated/tokens/semantics.g.dart89.9%✅
    lib/src/interfaces/countries.dart10%⛔️
    lib/src/theme/breakpoints.dart81.8%✅
    lib/src/theme/color_extensions.dart86.1%✅
    lib/src/theme/color_swatch.dart72%⛔️
    lib/src/theme/contrast.dart50%⛔️
    lib/src/theme/custom_theme.dart55.6%⛔️
    lib/src/theme/theme_service.dart18.5%⛔️
    lib/src/theme/tokens.dart50%⛔️
    lib/src/utils/debounce.dart100%✅
    lib/src/utils/extensions.dart100%✅
    lib/src/utils/enums.dart90%✅
    lib/src/utils/nothing.dart100%✅
    lib/src/utils/platform/platform_is.dart0%⛔️
    lib/src/utils/platform/universal_platform_vm.dart7.1%⛔️
    lib/src/utils/zeta.dart100%✅
    lib/src/utils/zeta_provider.dart100%✅

Created with Flutter code quality action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0084491):

https://zeta-flutter-main--pr-243-fix-avatar-badge-alignment-126n87h3.web.app

(expires Fri, 24 Jan 2025 11:06:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6

@thelukewalton
Copy link
Collaborator Author

I realise the jira ticket was not very specific - the component is still missing the outline on the bottom badge - essentially both top and bottom badges should be the same size:
image
(Figma is on right here)

Apart from the numerical status, which is pill shaped. This should be considered: https://www.figma.com/design/JesXQFLaPJLc1BdBM4sisI/%F0%9F%A6%93-ZDS---Components?node-id=20816-3661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelukewalton @DE7924