Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat-500] add Beatleader integration #632

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

silentrald
Copy link
Contributor

@silentrald silentrald commented Oct 29, 2024

#500

  • Auth flow (used OAuth2 PCKE)
  • Show leaderboard when clicking on the RANKED capsule
  • Check for authenticated routes that can be query important player details
  • Translation for locales
  • Finalize / Polish UI
  • [Maintainer] Setup BEATLEADER_CLIENT_ID and BEATLEADER_REDIRECT_URI for env variables

[Optional] e2e testing with a bot / test account?

Authentication Flow

beatleader-auth.mp4

Leaderboard View

as of 1baab70
image

Notes

  • Shouldn't be ready for 1.5.0 release.
  • Needs ScoreSaber Integration to fully close the issue.
  • Trying to avoid Singletons pattern and moving into a layered / interface based pattern (better testing and lifetime controls).
  • Added integration testing / possibly e2e testing as well.
  • Moved test and build config from package.json to jest.config.ts and electron-builder.ts for better typing.
  • Added dotenv module to for custom env variables for development and production.

@silentrald silentrald force-pushed the feat/500 branch 3 times, most recently from 4a0ca35 to 1ccdb05 Compare October 29, 2024 15:06
- removed macos testing
- refactored some components to use the service objects instead of destructing
- improved codeVerifier generation by sonarcloud request
- cleaned up some sonarcloud issues
Copy link

sonarqubecloud bot commented Nov 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant