S3v3 support #73
Open
S3v3 support #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 00bbfc0)
…ted error). Error not present in / was introduced after OpenS3v3 tag (safe/working). TODO: Create optional chai or mocha test option for S3 given user arguments to npm test. (cherry picked from commit c05eda0)
…end of block comments, throw Errors instead of strings so stacks are captured)
thenickdude
force-pushed
the
parquetjs-lite-s3v3
branch
from
a61bb36 to
4e255d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased entitycs's PR #64 (for adding compatibility with the AWS SDK v3) onto the latest parquetjs-lite commit, dropped whitespace changes in otherwise untouched parts of the files, fixed some other style issues, and fixed a failure to read the entire response from S3.