Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some changes to cohorts to keep Analysis compatible w/ Experience #33

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MaryanMorel
Copy link
Member

Add cache method to Cohort as it is now used by Experience

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@75c0291). Click here to learn what that means.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #33   +/-   ##
==========================================
  Coverage           ?   85.22%           
==========================================
  Files              ?       11           
  Lines              ?      636           
  Branches           ?        0           
==========================================
  Hits               ?      542           
  Misses             ?       94           
  Partials           ?        0           
Impacted Files Coverage Δ
scalpel/core/cohort.py 86.01% <20.00%> (ø)
scalpel/core/decorators.py 34.78% <0.00%> (ø)
scalpel/core/util.py 100.00% <0.00%> (ø)
scalpel/flattening/flat_table_collection.py 100.00% <0.00%> (ø)
scalpel/core/cohort_flow.py 92.85% <0.00%> (ø)
scalpel/core/cohort_collection.py 76.28% <0.00%> (ø)
scalpel/core/io.py 71.42% <0.00%> (ø)
scalpel/flattening/table.py 91.89% <0.00%> (ø)
scalpel/flattening/flat_table.py 98.24% <0.00%> (ø)
scalpel/core/descriptors.py 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c0291...91da649. Read the comment docs.

Copy link
Contributor

@ysebiat ysebiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ysebiat
ysebiat previously approved these changes Mar 10, 2020
…nd Experience

Rebase, update citation and contributors
@MaryanMorel MaryanMorel force-pushed the pre-exposure-compatibility branch from 342e3c9 to 91da649 Compare November 12, 2020 15:10
@MaryanMorel MaryanMorel requested a review from dsun0720 November 12, 2020 15:23
@MaryanMorel MaryanMorel self-assigned this Nov 12, 2020
@MaryanMorel MaryanMorel requested a review from kevtokev November 12, 2020 15:23
@MaryanMorel
Copy link
Member Author

@dsun0720 or @kevtokev could you do a quick review? This PR was already approved, I just rebased and added two tests to maintain the coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants