Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint to enable all three DataViews Gutenberg experiments #85

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

bph
Copy link
Collaborator

@bph bph commented Dec 11, 2024

These three experiments are enabled in one step.

  • Data Views: add Custom Views
  • Data Views: enable for Posts
  • Data Views: add Quick Edit

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@bph bph changed the title Blueprint that enables all three DataViews Gutenberg experiments Blueprint to enable all three DataViews Gutenberg experiments Dec 11, 2024
@zaerl
Copy link
Contributor

zaerl commented Jan 8, 2025

@bph I see this PR on draft. Do you think this needs additional changes, or is it ready?

@bph
Copy link
Collaborator Author

bph commented Jan 9, 2025

Thank you for the ping @zaerl I'll get back to it later this week.

@bph bph marked this pull request as ready for review January 14, 2025 15:28
@bph bph requested a review from zaerl January 14, 2025 15:28
@bph
Copy link
Collaborator Author

bph commented Jan 14, 2025

Hi @zaerl I just added the step to set the admin color to 'modern' and it's now ready to review/merge, if you agree,

Copy link
Contributor

@zaerl zaerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this. Good work.

@zaerl zaerl merged commit 6e8490f into trunk Jan 14, 2025
2 checks passed
@zaerl zaerl deleted the gb-more-experiments branch January 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants