Sort by path before outputting directory diff so that the order is always the same #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when doing a directory diff, the order in which the results were displayed was random, depending on thread execution and time it took for a file's diff.
This commit makes it so that the results are always shown in the same order.
It does this by diffing in parallel, then collecting the result, and then sorting it before printing it to the terminal.
This is the first time I have programmed in Rust. Any feedback is welcome.
I can also make a test for this, but as the order is random, the test might still pass even in the old situation.
I have run
cargo fmt
andcargo test
and have tested it manually in a different codebase.