fetch reducer #428
Merged
fetch reducer #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only expose main methods/classes re ViacomInc#426
acatl
commented
Sep 11, 2019
|
|
||
| For documentation on this module's api: [http://data-point.github.com/reducers/fetch](http://data-point.github.com/reducers/fetch). | ||
|
|
||
| For data-point's documentation visit its [home page](http://data-point.github.com) ([http://data-point.github.com](http://data-point.github.com)). |
There was a problem hiding this comment.
this and the url from above are wrong, will update them once we know their final destination.
Codecov Report
@@ Coverage Diff @@
## canary #428 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 29 35 +6
Lines 482 530 +48
Branches 74 84 +10
=====================================
+ Hits 482 530 +48
Continue to review full report at Codecov.
|
csarnataro
reviewed
Sep 12, 2019
csarnataro
previously approved these changes
Sep 13, 2019
… 426-fetch-reducer
… 426-fetch-reducer
… into 426-fetch-reducer
raingerber
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds a reducer to fetch resources, this reducer is just a wrapper for the node-fetch package.
closes #426
Checklist: