Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add more attributes to layoutelements #404

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat/add more attributes to layoutelements #404

wants to merge 7 commits into from
+86 −48

Conversation

badGarnet
Copy link
Collaborator

  • feat: add text_as_html and table_as_cells to LayoutElements class as new attributes
  • feat: replace the single valueed source attribute from TextRegions and LayoutElements with an array attribute sources

@badGarnet
feat: add more attributes to layoutelements
2daa2b7 
- add text_as_html and table_as_cells
- make sources an array, one value per element/region
@badGarnet
fix failing test
f4e7012 
- yolox do not have ocr or text extraction capability
- test was from a time when we mixed those into detection model
@badGarnet
bump version
cf050f3
@badGarnet
Merge remote-tracking branch 'origin/main' into feat/add-more-attribu…
3febb77 
…tes-to-layoutelements
@badGarnet
feat: add iter function
bb63f39
@badGarnet
tidy
862b989
@badGarnet
add docstrings
3e7d64c
@badGarnet badGarnet marked this pull request as ready for review January 18, 2025 00:20
@badGarnet badGarnet requested review from plutasnyy and tbs17 January 18, 2025 00:31
plutasnyy
plutasnyy approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@plutasnyy plutasnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plutasnyy plutasnyy plutasnyy approved these changes

@christinestraub christinestraub Awaiting requested review from christinestraub

@tbs17 tbs17 Awaiting requested review from tbs17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badGarnet @plutasnyy