-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove code related to embedded text extraction #349
Merged
christinestraub
merged 10 commits into
main
from
refactor/remove-embedded-text-related-code
May 21, 2024
Merged
refactor: remove code related to embedded text extraction #349
christinestraub
merged 10 commits into
main
from
refactor/remove-embedded-text-related-code
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d `ImageTextRegion` classes
MthwRobinson
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is the logic that moved over in Unstructured-IO/unstructured#3061 right?
Yes, that's right. |
github-merge-queue bot
pushed a commit
to Unstructured-IO/unstructured
that referenced
this pull request
May 21, 2024
This PR adds the ability to fill inferred elements text from embedded text (`pdfminer`) without depending on `unstructured-inference` library. This PR is the second part of moving embedded text related code from `unstructured-inference` to `unstructured` and works together with Unstructured-IO/unstructured-inference#349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all code related to filling inferred elements text from embedded text (
pdfminer
). This PR is the first part of moving embedded text related code fromunstructured-inference
tounstructured
and works together with Unstructured-IO/unstructured#3061.