Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove code related to embedded text extraction #349

Merged
merged 10 commits into from
May 21, 2024

Conversation

christinestraub
Copy link
Contributor

@christinestraub christinestraub commented May 20, 2024

This PR removes all code related to filling inferred elements text from embedded text (pdfminer). This PR is the first part of moving embedded text related code from unstructured-inference to unstructured and works together with Unstructured-IO/unstructured#3061.

@christinestraub christinestraub marked this pull request as ready for review May 21, 2024 18:42
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is the logic that moved over in Unstructured-IO/unstructured#3061 right?

@christinestraub
Copy link
Contributor Author

LGTM. This is the logic that moved over in Unstructured-IO/unstructured#3061 right?

Yes, that's right.

github-merge-queue bot pushed a commit to Unstructured-IO/unstructured that referenced this pull request May 21, 2024
This PR adds the ability to fill inferred elements text from embedded
text (`pdfminer`) without depending on `unstructured-inference` library.
This PR is the second part of moving embedded text related code from
`unstructured-inference` to `unstructured` and works together with
Unstructured-IO/unstructured-inference#349.
@christinestraub christinestraub merged commit 81549a7 into main May 21, 2024
5 of 7 checks passed
@christinestraub christinestraub deleted the refactor/remove-embedded-text-related-code branch May 21, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants