chore: streamline kwarg handling #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qued
changed the title
badGarnet
reviewed
Oct 20, 2023
Comment on lines
+473
to
+474
| extract_images_in_pdf: bool = False, | ||
| image_output_dir_path: Optional[str] = None, |
There was a problem hiding this comment.
what's the guide line here? When do we explicit set and when do we implicitly trust a kwarg does something down the call stack? And why are those two explicit here? It doesn't seem those two parameters are modified in this function and they are just passing through?
There was a problem hiding this comment.
These are explicit since we don't want them passed down to get_model, but we do want them passed down to .from_file
cragwolfe
reviewed
Oct 20, 2023
CHANGELOG.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| ## 0.7.10-dev1 | |||
| ## 0.7.10-dev2 | |||
There was a problem hiding this comment.
please make this is a release version
badGarnet
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves kwarg handling so that kwargs are handled explicitly when needed, and suppressed otherwise.
Testing:
CI should pass.