Skip to content

Commit

Permalink
Temporarily revert renovate updates. (#235)
Browse files Browse the repository at this point in the history
I was too hasty in merging #233, this needs
`actions/upload-artifact@v4`. #234 only updated
`actions/upload-pages-artifact` to _its_ `v3` which is only
`actions/upload-artifact@v3` under the hood.

This PR just reverts the last two commits and downgrades the two
actions. We can live with old versions until
actions/upload-pages-artifact#76 is merged and
makes it into production. Then we can re-update.

Also, all of this wasn't caught in CI because we don't test the webpage
deployment in CI. (For obvious reasons.)

In terms of the doc failure, it does ["fail" in the step
before](https://github.com/UCL-ARC/python-tooling/actions/runs/7265323304/job/19794807367#step:6:65)
deployment where the upload action doesn't upload. We might want to
investigate a `--no-really-we-want-any-error-as-a-fail` option and/or
add the doc build to the required checks (I don't think that would have
caught this bug, but we probably want to run it anyway).
  • Loading branch information
samcunliffe authored Dec 20, 2023
1 parent c8ba065 commit b3039d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
JEKYLL_ENV: production
- name: Upload artifact
# Automatically uploads an artifact from the './_site' directory by default
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@v2
with:
path: docs/_site

Expand All @@ -67,4 +67,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
uses: actions/deploy-pages@v3

0 comments on commit b3039d2

Please sign in to comment.