Added a header to index.tsx

[fyang151]

Description

• Resolves Add UBC Sailbot Header to Website  #89

Added Header component to index.tsx
Created Header.tsx inside components
Added SailbotLogo.png inside public

Verification

• there was some white space around the header, used negative margin to eliminate this, looking for more intuitive solution

Resources

[jahn18]

Solid work!

[jahn18]

Todo:

• Add the Header component to it's own directory Header.
• Create a custom .css file for the styles used in the component (take a look at how https://github.com/UBCSailbot/website/blob/main/pages/style.module.css is used for reference)
• If possible, make the header sticky and not use up vertical space.

[jahn18]

Very minor comments:

• You left a console.log in the code so that needs to be removed.
• The pipeline is failing because of lint checks. To fix this, you want to go into the docker desktop, click on the website container, go into the tab labelled exec, then run the commands npm run format and npm run lint. Then commit whatever files the linter has reformatted.

Thanks for getting rid of the extra vertical scroll :)

[fyang151]

ohh right thanks john sry abt that ill fix that soon

…

On Thu, Feb 8, 2024 at 4:06 PM John Ahn ***@***.***> wrote: ***@***.**** requested changes on this pull request. Very minor comments: - You left a console.log in the code so that needs to be removed. - The pipeline is failing because of lint checks. To fix this, you want to go into the docker desktop, click on the website container, go into the tab labelled exec, then run the commands npm run format and npm run lint. Then commit whatever files the linter has reformatted. Thanks for getting rid of the extra vertical scroll :) ------------------------------ In views/components/Header/Header.tsx <#91 (comment)>: > @@ -0,0 +1,18 @@ +import React from 'react'; +import styles from './header.module.css'; + +function Header() { + console.log(styles); Please remove the console.log — Reply to this email directly, view it on GitHub <#91 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARI733HMJ4QWO3ZWDLOA2ZTYSVR63AVCNFSM6AAAAABCWOTK3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZRGQ2TIOBXGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jahn18]

Thanks, looks great!