Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Added line chart labels for y axis in each chart of dashboard #87

Closed
wants to merge 1 commit into from
Closed

Added line chart labels for y axis in each chart of dashboard #87

wants to merge 1 commit into from

Conversation

fyang151
Copy link
Contributor

@fyang151 fyang151 commented Jan 27, 2024 •
edited
Loading

Description

Verification

  • Changed LineChart and MultiLineChart props to add unit, Added these units to the Y axis of each chart, defined a unit for each LineChart and MultiLineChart component in DashboardContainer

Resources

@fyang151 fyang151 requested a review from jahn18 as a code owner January 27, 2024 23:29
@fyang151 fyang151 changed the title Line chart labels Added line chart labels for y axis in each chart of dashboard Jan 27, 2024
@jahn18
Copy link
Member

jahn18 commented Jan 29, 2024

@JordanChen123 after your interview, could you take a look at this? Once you give the thumbs up, let me know and I'll do the final pass.

@JordanChen123
Copy link
Contributor

@jahn18 looks good to me!

jahn18
jahn18 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@jahn18 jahn18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jahn18 jahn18 closed this Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jahn18 jahn18 jahn18 approved these changes

@JordanChen123 JordanChen123 Awaiting requested review from JordanChen123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Units of Measurement to LineCharts
3 participants
@fyang151 @jahn18 @JordanChen123