Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Implement fluid simulation template classes #66

Merged
merged 12 commits into from
Feb 10, 2024
Merged

Implement fluid simulation template classes #66

merged 12 commits into from
Feb 10, 2024

Conversation

eomielan
Copy link
Member

@eomielan eomielan commented Feb 4, 2024

Description

  • This pull request introduces template classes for fluid generation and force computation on a medium.

@eomielan eomielan added enhancement New feature or request physics-engine Issue for physics engine labels Feb 4, 2024
@eomielan eomielan self-assigned this Feb 4, 2024
@eomielan eomielan requested a review from DFriend01 as a code owner February 4, 2024 00:17
DFriend01
DFriend01 suggested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few changes that need to be made. Let me know if you want to revisit the discussion and maybe we can just do this template together because we really need to make sure it's right

boat_simulator/nodes/physics_engine/fluid_generation.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_generation.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_generation.py Show resolved Hide resolved
boat_simulator/nodes/physics_engine/force_computation.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/force_computation.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/force_computation.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/force_computation.py Outdated Show resolved Hide resolved
@eomielan eomielan requested a review from DFriend01 February 7, 2024 00:23
DFriend01
DFriend01 suggested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments based on our discussion on Thursday

boat_simulator/nodes/physics_engine/fluid_generation.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
@eomielan eomielan requested a review from DFriend01 February 9, 2024 07:16
@eomielan eomielan requested a review from DFriend01 February 10, 2024 19:04
DFriend01
DFriend01 approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@eomielan eomielan merged commit 050637d into main Feb 10, 2024
12 checks passed
@eomielan eomielan deleted the user/eomielan/fluid-simulation-templates branch February 10, 2024 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DFriend01 DFriend01 DFriend01 approved these changes

Assignees

@eomielan eomielan

Labels
enhancement New feature or request physics-engine Issue for physics engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eomielan @DFriend01