Skip to content

Commit

Permalink
Reduce Javadoc warnings.
Browse files Browse the repository at this point in the history
  • Loading branch information
TomasMikula committed Jul 2, 2014
1 parent 39d0aa7 commit e5a5280
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 12 deletions.
7 changes: 6 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ targetCompatibility = '1.8'
group = 'org.fxmisc.easybind'

dependencies {
testCompile group: 'junit', name: 'junit', version: '4.+'
testCompile group: 'junit', name: 'junit', version: '[4.0,)'
}

javadoc {
// ignore missing Javadoc comments or tags
options.addStringOption('Xdoclint:all,-missing', '-quiet')
}

task javadocJar(type: Jar, dependsOn: javadoc) {
Expand Down
1 change: 0 additions & 1 deletion src/main/java/org/fxmisc/easybind/PreboundBinding.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
/**
* Object binding that binds to its dependencies on creation
* and unbinds from them on dispose.
* @param <T>
*/
public abstract class PreboundBinding<T> extends ObjectBinding<T> implements MonadicBinding<T> {
private final Observable[] dependencies;
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/org/fxmisc/easybind/Subscription.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public interface Subscription {
* Returns a new aggregate subscription whose {@link #unsubscribe()}
* method calls {@code unsubscribe()} on both this subscription and
* {@code other} subscription.
* @param other
*/
default Subscription and(Subscription other) {
return new BiSubscription(this, other);
Expand All @@ -19,7 +18,6 @@ default Subscription and(Subscription other) {
/**
* Returns a new aggregate subscription whose {@link #unsubscribe()}
* method calls {@code unsubscribe()} on all arguments to this method.
* @param subs
*/
static Subscription multi(Subscription... subs) {
switch(subs.length) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

/**
* Adds monadic operations to {@link ObservableValue}.
* @param <T>
*/
public interface MonadicObservableValue<T> extends ObservableObjectValue<T> {

Expand Down Expand Up @@ -116,7 +115,6 @@ default MonadicBinding<T> orElse(ObservableValue<T> other) {
* as this ObservableValue when the value satisfies the predicate
* and is empty when this ObservableValue is empty or its value
* does not satisfy the given predicate.
* @param p
*/
default MonadicBinding<T> filter(Predicate<? super T> p) {
return new PreboundBinding<T>(this) {
Expand Down Expand Up @@ -147,7 +145,6 @@ protected U computeValue() {
* Returns a new ObservableValue that, when this ObservableValue holds
* value {@code x}, holds the value held by {@code f(x)}, and is empty
* when this ObservableValue is empty.
* @param f
*/
default <U> MonadicBinding<U> flatMap(Function<? super T, ObservableValue<U>> f) {
return new FlatMapBinding<>(this, f);
Expand Down Expand Up @@ -178,8 +175,6 @@ default <U> PropertyBinding<U> selectProperty(Function<? super T, Property<U>> f
/**
* Starts a selection chain. A selection chain is just a more efficient
* equivalent to a chain of flatMaps.
* @param selector
* @return
*/
default <U> SelectBuilder<U> select(Function<? super T, ObservableValue<U>> selector) {
return SelectBuilder.startAt(this).select(selector);
Expand Down Expand Up @@ -207,8 +202,6 @@ default <U> SelectBuilder<U> select(Function<? super T, ObservableValue<U>> sele
* // later
* observable.removeListener();
* }</pre>
*
* @param listener
*/
default Subscription subscribe(InvalidationListener listener) {
addListener(listener);
Expand All @@ -219,7 +212,6 @@ default Subscription subscribe(InvalidationListener listener) {
* Adds a change listener and returns a Subscription that can be
* used to remove that listener. See the example at
* {@link #subscribe(InvalidationListener)}.
* @param listener
*/
default Subscription subscribe(ChangeListener<? super T> listener) {
addListener(listener);
Expand Down

0 comments on commit e5a5280

Please sign in to comment.