chore: port sports-league-scheduling quickstart example from Java to Python #685

PatrickDiallo23 · 2025-01-15T15:02:12Z

Description of the change

Port the sports-league-scheduling quickstart example from Java to Python while keeping the same functionality.

Checklist

Development

The changes have been covered with tests, if necessary.
You have a green build, with the exception of the flaky tests.
UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
The network calls work for all modules affected by your changes (e.g., solving a problem).
The console messages are validated for all modules affected by your changes.

Code Review

This pull request includes an explanatory title and description.
The GitHub issue is linked.
At least one other engineer has approved the changes.
After PR is merged, inform the reporter.

…Python

triceo · 2025-01-15T15:07:59Z

Thanks for the contribution, @PatrickDiallo23!
We'll take a look when time permits.

Christopher-Chianelli

Thanks for the PR @PatrickDiallo23! I am impressed with the quality of the port. Some suggestions for improvement + consistency with the other quickstarts.

python/sports-league-scheduling/static/index.html

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py

python/sports-league-scheduling/src/sports_league_scheduling/demo_data.py

python/sports-league-scheduling/src/sports_league_scheduling/domain.py

python/sports-league-scheduling/tests/test_constraints.py

…-league-scheduling example

PatrickDiallo23 · 2025-01-16T07:13:35Z

Hello @Christopher-Chianelli! I did another commit where I applied your code suggestions. Please review. Thank you!

Christopher-Chianelli

Mild formatting changes. It appears you missed the requested changes that were hidden by default (since GitHub automatically hides requested changes in the middle when there are many requests). Do the missed requested changes + the formatting ones, then it'll LGTM.

Christopher-Chianelli · 2025-01-16T15:09:53Z

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py

@@ -81,7 +81,7 @@ def start_to_away_hop(constraint_factory: ConstraintFactory) -> Constraint:
            .for_each(Match)
            .if_not_exists(Round, Joiners.equal(lambda match: match.round.index - 1,
                                                lambda match_round: match_round.index))
-            .penalize(HardSoftScore.ONE_SOFT, away_home_match_distance_lambda)
+            .penalize(HardSoftScore.ONE_SOFT, lambda match: (match.away_team.get_distance(match.home_team)))


Parenthesis uneccessary

Suggested change

.penalize(HardSoftScore.ONE_SOFT, lambda match: (match.away_team.get_distance(match.home_team)))

.penalize(HardSoftScore.ONE_SOFT, lambda match: match.away_team.get_distance(match.home_team))

Christopher-Chianelli · 2025-01-16T15:10:11Z

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py

@@ -91,7 +91,7 @@ def home_to_away_hop(constraint_factory: ConstraintFactory) -> Constraint:
            .join(Match,
                  Joiners.equal(lambda match: match.home_team, lambda match: match.away_team),
                  Joiners.equal(lambda match: match.round.index + 1, lambda match: match.round.index))
-            .penalize(HardSoftScore.ONE_SOFT, home_matches_distance_lambda)
+            .penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: (match.home_team.get_distance(other_match.home_team)))


Suggested change

.penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: (match.home_team.get_distance(other_match.home_team)))

.penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: match.home_team.get_distance(other_match.home_team))

Christopher-Chianelli · 2025-01-16T15:10:29Z

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py

@@ -101,7 +101,7 @@ def away_to_away_hop(constraint_factory: ConstraintFactory) -> Constraint:
            .join(Match,
                  Joiners.equal(lambda match: match.away_team, lambda match: match.away_team),
                  Joiners.equal(lambda match: match.round.index + 1, lambda match: match.round.index))
-            .penalize(HardSoftScore.ONE_SOFT, home_matches_distance_lambda)
+            .penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: (match.home_team.get_distance(other_match.home_team)))


Suggested change

.penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: (match.home_team.get_distance(other_match.home_team)))

.penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: match.home_team.get_distance(other_match.home_team))

Christopher-Chianelli · 2025-01-16T15:10:39Z

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py

@@ -111,45 +111,22 @@ def away_to_home_hop(constraint_factory: ConstraintFactory) -> Constraint:
            .join(Match,
                  Joiners.equal(lambda match: match.away_team, lambda match: match.home_team),
                  Joiners.equal(lambda match: match.round.index + 1, lambda match: match.round.index))
-            .penalize(HardSoftScore.ONE_SOFT, home_away_matches_distance_lambda)
+            .penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: (match.home_team.get_distance(match.away_team)))


Suggested change

.penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: (match.home_team.get_distance(match.away_team)))

.penalize(HardSoftScore.ONE_SOFT, lambda match, other_match: match.home_team.get_distance(match.away_team))

Christopher-Chianelli · 2025-01-16T15:11:01Z

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py


 def away_to_end_hop(constraint_factory: ConstraintFactory) -> Constraint:
    return (constraint_factory
            .for_each(Match)
            .if_not_exists(Round, Joiners.equal(lambda match: match.round.index + 1,
                                                lambda match_round: match_round.index))
-            .penalize(HardSoftScore.ONE_SOFT, home_away_match_distance_lambda)
+            .penalize(HardSoftScore.ONE_SOFT, lambda match: (match.home_team.get_distance(match.away_team)))


Suggested change

.penalize(HardSoftScore.ONE_SOFT, lambda match: (match.home_team.get_distance(match.away_team)))

.penalize(HardSoftScore.ONE_SOFT, lambda match: match.home_team.get_distance(match.away_team))

chore: port sports-league-scheduling quickstart example from Java to …

a320dd9

…Python

triceo requested a review from Christopher-Chianelli January 15, 2025 15:08

Christopher-Chianelli requested changes Jan 15, 2025

View reviewed changes

chore: apply code review suggestions and refine Python port of sports…

198589b

…-league-scheduling example

PatrickDiallo23 requested a review from Christopher-Chianelli January 16, 2025 07:13

Christopher-Chianelli requested changes Jan 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: port sports-league-scheduling quickstart example from Java to Python #685

chore: port sports-league-scheduling quickstart example from Java to Python #685

PatrickDiallo23 commented Jan 15, 2025 •

edited

Loading

triceo commented Jan 15, 2025

Christopher-Chianelli left a comment

PatrickDiallo23 commented Jan 16, 2025

Christopher-Chianelli left a comment

Christopher-Chianelli Jan 16, 2025

Christopher-Chianelli Jan 16, 2025

Christopher-Chianelli Jan 16, 2025

Christopher-Chianelli Jan 16, 2025

Christopher-Chianelli Jan 16, 2025

	.penalize(HardSoftScore.ONE_SOFT, lambda match: (match.away_team.get_distance(match.home_team)))
	.penalize(HardSoftScore.ONE_SOFT, lambda match: match.away_team.get_distance(match.home_team))

chore: port sports-league-scheduling quickstart example from Java to Python #685

Are you sure you want to change the base?

chore: port sports-league-scheduling quickstart example from Java to Python #685

Conversation

PatrickDiallo23 commented Jan 15, 2025 • edited Loading

Description of the change

Checklist

Development

Code Review

triceo commented Jan 15, 2025

Christopher-Chianelli left a comment

Choose a reason for hiding this comment

PatrickDiallo23 commented Jan 16, 2025

Christopher-Chianelli left a comment

Choose a reason for hiding this comment

Christopher-Chianelli Jan 16, 2025

Choose a reason for hiding this comment

Christopher-Chianelli Jan 16, 2025

Choose a reason for hiding this comment

Christopher-Chianelli Jan 16, 2025

Choose a reason for hiding this comment

Christopher-Chianelli Jan 16, 2025

Choose a reason for hiding this comment

Christopher-Chianelli Jan 16, 2025

Choose a reason for hiding this comment

PatrickDiallo23 commented Jan 15, 2025 •

edited

Loading