Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package-lock: compile cookies #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

package-lock: compile cookies #66

wants to merge 1 commit into from

Conversation

BibianaC
Copy link
Member

No description provided.

@BibianaC BibianaC requested a review from michaelwood March 30, 2022 12:36
@michaelwood
Copy link
Member

The package-lock file that is upgraded here sounds like a good maintenance thing to do. It would be good to amend the commit message to just something like "upgrade packages". As this is effectively the node/npm equivalent of upgrading requirements.txt in python i.e. pip-compile requirements.in --upgrade . Thanks

michaelwood
michaelwood requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@michaelwood michaelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As above)

@BibianaC
Copy link
Member Author

@michaelwood I have changed the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwood michaelwood michaelwood requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BibianaC @michaelwood