-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker image for MapR Client #20
base: mapr-52
Are you sure you want to change the base?
Conversation
teradatalabs/mapr52-base/Dockerfile
Outdated
@@ -33,7 +33,7 @@ RUN yum update -y \ | |||
# INSTALL MapR | |||
&& yum install -y mapr-fileserver mapr-nfs mapr-nodemanager mapr-cldb \ | |||
&& yum install -y mapr-zookeeper mapr-resourcemanager mapr-historyserver \ | |||
&& yum install -y mapr-webserver mapr-gateway \ | |||
&& yum install -y mapr-webserver mapr-gateway mapr-httpfs \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add why this is needed in the commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am removing this commit since @AS186170 has already included it in mapr-52 base.
cca1c20
to
ff0e6bd
Compare
@@ -0,0 +1,9 @@ | |||
# mapr52-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
badges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the heading should be the image name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, name the image mapr-client
MAINTAINER Teradata Docker Team <[email protected]> | ||
|
||
ADD files/maprtech.repo /etc/yum.repos.d/maprtech.repo | ||
RUN yum update -y \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add entrypoint and command so that the image can be used like a standalone program
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#entrypoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a default set of command that needs to be executed for this container.
The first step is to configure the client - https://github.com/Teradata/presto/pull/528/files#diff-d5fa118c169436bb50bbd774dc84d440R51
And this needs to be done only once, not every time you log into the container.
I can have CMD as bash, but it currently works without that.
mapr-client $docker run -it mapr-client
[root@aec1a9c03a4c /]#
So not sure if we need ENTRYPOINT/CMD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind :) our slack conversation and your comment above have showed me that there's no point in having the entrypoint/cmd
please consult @petroav on licensing of mapr products and our resdistribution of them in docker images |
No description provided.