Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”— :: (#29) ํ™ˆ ์Šคํฌ๋ฆฐ ํผ๋ธ”๋ฆฌ์‹ฑ #31

Conversation

Tmdhoon2
Copy link
Member

@Tmdhoon2 Tmdhoon2 commented Feb 3, 2024

๊ฐœ์š”

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-02-04 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 7 34 38

์ž‘์—… ๋‚ด์šฉ

  • HomeNavigation ๊ตฌํ˜„
  • HomeScreen ๊ตฌํ˜„
  • RootNavigation ๊ตฌํ˜„
  • HomeNavigation ์—ฐ๊ฒฐ

ํ•  ๋ง

๋‚ด๋ถ€ ์•„์ด์ฝ˜๋“ค ์„œ๋ฒ„ ์—ฐ๋™ํ• ๋•Œ๋Š” ๋ฐ”๊ฟ”์•ผ ํ•ด์š”

@Tmdhoon2 Tmdhoon2 added the ํผ๋ธ”๋ฆฌ์‹ฑ ํ™”๋ฉด์„ ํผ๋ธ”๋ฆฌ์‹ฑ ํ•ฉ๋‹ˆ๋‹ค. label Feb 3, 2024
@Tmdhoon2 Tmdhoon2 self-assigned this Feb 3, 2024
@Tmdhoon2 Tmdhoon2 linked an issue Feb 3, 2024 that may be closed by this pull request
2 tasks
@@ -7,6 +7,7 @@ import androidx.compose.ui.Modifier
import androidx.navigation.compose.NavHost
import androidx.navigation.compose.rememberNavController
import team.retum.jobisandroidv2.navigation.NAVIGATION_AUTH
import team.retum.jobisandroidv2.navigation.NAVIGATION_MAIN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ ์•ˆ์“ฐ์—ฌ์š”

pagerState: PagerState,
menus: List<MenuItem>,
) {
Column(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ ์ปฌ๋Ÿผ์„ ์—†์• ๊ณ  ํƒ‘์•ฑ๋ฐ”๋ฅผ ๋ฐ‘์— ์ปฌ๋Ÿผ์— ๋„ฃ์„ ์ˆ˜ ์žˆ์ง€ ์•Š์„๊นŒ์š”?

Copy link
Member Author

@Tmdhoon2 Tmdhoon2 Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-02-04 แ„‹แ…ฉแ„’แ…ฎ 7 09 18

์ง€์› ํ˜„ํ™ฉ์ด ๋Š˜์–ด๋‚˜๋Š” ๊ฒฝ์šฐ์— ํ™”๋ฉด ์Šคํฌ๋กค์ด ๋˜์–ด์•ผ ํ•˜๋Š”๋ฐ, ํƒ‘๋ฐ”๋Š” ๋งจ ์œ„ ์ƒ๋‹จ์— ๊ณ ์ •๋˜์–ด์•ผ ํ•ด์„œ ๊ทธ๋Ÿฐ ๋ฐฉ์‹์œผ๋กœ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹น

onClick = {},
enabled = false,
) {
Row(modifier = Modifier.padding(24.dp)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ row๊ฐ€ ์žˆ๋Š” ์ด์œ ๊ฐ€ ๋ญ”๊ฐ€์š”?

Copy link
Member Author

@Tmdhoon2 Tmdhoon2 Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ์•„์ด์ฝ˜ ํ•˜๋‚˜ ์ž‘์—…ํ•˜๋Š”๊ฑธ ๊นœ๋นกํ–ˆ์Šต๋‹ˆ๋‹น
์ˆ˜์ •ํ–ˆ์–ด์šฉ

Row(
modifier = Modifier
.align(Alignment.Start)
.padding(vertical = 10.dp),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ ํŒจ๋”ฉ์ด ๋””์ž์ธ์ด๋ž‘ ๋‹ค๋ฅธ๊ฒƒ ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹น

color = JobisTheme.colors.onSurfaceVariant,
)
}
Column(verticalArrangement = Arrangement.spacedBy(8.dp)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ column์€ ํ•„์š” ์—†์„๊ฒƒ ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-02-04 แ„‹แ…ฉแ„’แ…ฎ 7 34 07

์ด ๋ถ€๋ถ„์ด LazyColumn์ด ์•„๋‹ˆ๋ผ Column ์•ˆ์—์„œ ๋ฐ˜๋ณต๋ฌธ ๋Œ๋ฆฌ๋Š” ํ˜•์‹์œผ๋กœ ๊ตฌํ˜„์„ ํ•ด์„œ ํ•ญ๋ชฉ๋งˆ๋‹ค ํŒจ๋”ฉ์„ ์ฃผ๊ธฐ ์œ„ํ•ด์„  ์ด Column์ด ํ•„์š”ํ•ด์š”

@Tmdhoon2 Tmdhoon2 requested a review from rladmsdh February 4, 2024 10:41
@Tmdhoon2 Tmdhoon2 merged commit 32045d9 into develop Feb 4, 2024
1 check passed
@Tmdhoon2 Tmdhoon2 deleted the feature/29-ํ™ˆ-์Šคํฌ๋ฆฐ-ํผ๋ธ”๋ฆฌ์‹ฑ branch February 4, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ํผ๋ธ”๋ฆฌ์‹ฑ ํ™”๋ฉด์„ ํผ๋ธ”๋ฆฌ์‹ฑ ํ•ฉ๋‹ˆ๋‹ค.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ํ™ˆ ์Šคํฌ๋ฆฐ ํผ๋ธ”๋ฆฌ์‹ฑ
3 participants