๐ :: (#24) ๋น๋ฐ๋ฒํธ ์ค์ ์คํฌ๋ฆฐ ํผ๋ธ๋ฆฌ์ฑ #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkuiery
reviewed
Jan 30, 2024
feature/signup/src/main/java/team/retum/signup/ui/SettingPasswordScreen.kt
Show resolved
Hide resolved
Tmdhoon2
requested changes
Jan 31, 2024
app/src/main/java/team/retum/jobisandroidv2/navigation/AuthNavigation.kt
Show resolved
Hide resolved
app/src/main/java/team/retum/jobisandroidv2/navigation/AuthNavigation.kt
Outdated
Show resolved
Hide resolved
feature/signup/src/main/java/team/retum/signup/ui/SettingPasswordScreen.kt
Show resolved
Hide resolved
feature/signup/src/main/java/team/retum/signup/ui/SettingPasswordScreen.kt
Outdated
Show resolved
Hide resolved
feature/signup/src/main/java/team/retum/signup/ui/InputEmailScreen.kt
Outdated
Show resolved
Hide resolved
feature/signup/src/main/java/team/retum/signup/navigation/InputEmailScreen.kt
Outdated
Show resolved
Hide resolved
Tmdhoon2
previously approved these changes
Jan 31, 2024
rladmsdh
reviewed
Jan 31, 2024
|
|
||
| fun NavGraphBuilder.settingPassword( | ||
| onBackClick: () -> Unit, | ||
| ){ |
| @@ -0,0 +1,85 @@ | |||
| package team.retum.signup.ui | |||
|
|
|||
| import androidx.compose.foundation.Image | |||
There was a problem hiding this comment.
์์ฐ๋ import ์ง์ฐ๊ธฐ
| ) | ||
| Spacer(modifier = Modifier.weight(1f)) | ||
| JobisButton( | ||
| modifier = Modifier.padding(bottom = 24.dp), |
There was a problem hiding this comment.
์ด๊ฑฐ ๋์์ธ์ด๋ ์๋ง์
bottom = 24.dp๊ฐ ์๋๋ผ vertical = 12.dp์ผ
| @@ -7,11 +7,15 @@ import team.retum.landing.NAVIGATION_LANDING | |||
| import team.retum.landing.landing | |||
There was a problem hiding this comment.
์ฌ๊ธฐ ์์ฐ๋ import ์ง์์ค
rladmsdh
reviewed
Jan 31, 2024
| password = { password }, | ||
| checkPassword = { checkPassword }, | ||
| onPasswordChange = { password = it }, | ||
| onCheckPassword = { password = it }, |
There was a problem hiding this comment.
์ฌ๊ธฐ ์๋ชป๋์ด์๋๋ฐ viewModel ์ถ๊ฐํ๋ฉด ๋ฐ๊ฟ์ค
Tmdhoon2
approved these changes
Feb 2, 2024
rladmsdh
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๊ฐ์
๋น๋ฐ๋ฒํธ ์ค์ ์คํฌ๋ฆฐ์ ํผ๋ธ๋ฆฌ์ฑํ์ต๋๋ค.
์์ ๋ด์ฉ
ํ ๋ง