Apply suggestions from code review

Co-authored-by: David Hebbeker <[email protected]>
Task-Tracker-Systems · Oct 27, 2023 · 835d827 · 835d827
1 parent 8bfef18
commit 835d827
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/platformio.ini b/platformio.ini
@@ -30,11 +30,10 @@ build_src_filter = +<*> -<.git/> -<.svn/>
 ; for version requirements see https://docs.platformio.org/en/stable/core/userguide/pkg/cmd_install.html#cmd-pkg-install-requirements
 lib_deps = 
   adafruit/Adafruit SSD1306@~2.5.3
-  lvgl@~8.3.7
+  lvgl@^8.3
+
 build_flags =
-  -DLV_KCONFIG_IGNORE         ; lvgl: skip some default values that are used for ESP-IDF
   -DLV_CONF_INCLUDE_SIMPLE    ; lvgl: use a config file located in source directory
-  -Wno-discarded-qualifiers   ; removes warings about discarding qualifiers, but creates "notes" that it has no effect on C++ compiler
   -I"src"                     ; adds src directory to be used as include directory
 
 ;general serial monitor baud rate

diff --git a/src/display.cpp b/src/display.cpp
@@ -88,7 +88,7 @@ void setup_display()
 
     // create first text in lvgl
     lv_obj_t *label = lv_label_create(lv_scr_act());
-    lv_label_set_text(label, reinterpret_cast<const char *>(F("LVGL is up")));
+    lv_label_set_text(label, "LVGL is up");
     lv_obj_align(label, LV_ALIGN_TOP_MID, 0, 0);
 
     // display lvgl screen