Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type coverage #889

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Add type coverage #889

merged 5 commits into from
Oct 23, 2023

Conversation

lukaszuznanski
Copy link
Contributor

Resolves: #830

@oliverklee oliverklee added this to the 3.1.0: New features milestone Jul 11, 2023
@oliverklee oliverklee added the enhancement New feature or request label Jul 11, 2023
phpstan.neon Outdated Show resolved Hide resolved
@lukaszuznanski
Copy link
Contributor Author

Damn, I clicked on update branch and merged main into branch... sorry, let's check if there is way to disable this button, or change it's behavior. I will fix this error in functional tests.

@oliverklee oliverklee force-pushed the Feature/Add-type-coverage branch from a984e9f to c7f0205 Compare August 29, 2023 15:43
@oliverklee
Copy link
Contributor

I've fixed this now:

git switch Feature/Add-type-coverage
git reset --hard a14f676
git rebase
git push -f

@lukaszuznanski
Copy link
Contributor Author

I changed it to 100, 100 and 95 for properties. We can update it to 100, but first we need to add property type. This should work for now. Let's do it in another PR.

@lukaszuznanski lukaszuznanski force-pushed the Feature/Add-type-coverage branch from 04661a3 to 3d85f61 Compare October 17, 2023 21:19
@lukaszuznanski lukaszuznanski marked this pull request as ready for review October 17, 2023 21:19
@lukaszuznanski lukaszuznanski self-assigned this Oct 17, 2023
@lukaszuznanski lukaszuznanski force-pushed the Feature/Add-type-coverage branch from 3d85f61 to 07e9b20 Compare October 17, 2023 21:20
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It should get an entry in the changelog, though.

@lukaszuznanski lukaszuznanski force-pushed the Feature/Add-type-coverage branch from 1956c84 to 937f955 Compare October 23, 2023 08:23
@oliverklee oliverklee merged commit 472f08a into main Oct 23, 2023
42 checks passed
@oliverklee oliverklee deleted the Feature/Add-type-coverage branch October 23, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement type coverage calculation
2 participants