Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Avoid unsetting almost all PHP-CS-Fixes rules #1535

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[BUGFIX] Avoid unsetting almost all PHP-CS-Fixes rules #1535

merged 1 commit into from
Jan 3, 2025

Conversation

oliverklee
Copy link
Contributor

Followup to #1533

@oliverklee oliverklee added the bug Something isn't working label Dec 31, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Dec 31, 2024
@oliverklee oliverklee self-assigned this Dec 31, 2024
DanielSiepmann
DanielSiepmann approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@DanielSiepmann DanielSiepmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@DanielSiepmann DanielSiepmann force-pushed the bugfix/cs-fixer-config branch from 3525890 to 22c89bb Compare January 3, 2025 07:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12594588443

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 12594582264: 0.0%
Covered Lines: 101
Relevant Lines: 101
💛 - Coveralls

@DanielSiepmann DanielSiepmann merged commit 318f978 into main Jan 3, 2025
56 checks passed
@DanielSiepmann DanielSiepmann deleted the bugfix/cs-fixer-config branch January 3, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSiepmann DanielSiepmann DanielSiepmann approved these changes

@linxpinx linxpinx Awaiting requested review from linxpinx

@lukaszuznanski lukaszuznanski Awaiting requested review from lukaszuznanski

Assignees

@oliverklee oliverklee

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @DanielSiepmann