Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Issue #3566: Check rootline for feGroups from page with extendToSubpages set #3926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timhorstmann
Copy link

What this pr does

When fetching usergroups to build a TSFE, the fe_groups field from current page could be empty. But there might be a page in the rootline with feGroups and extendToSubpages set.

This PR collects the feGroups from the rootline in this case.
The code is inspired from TYPO3\CMS\Backend\Utility\BackendUtility::ADMCMD_previewCmds

How to test

See #3566

Fixes: #3566

Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timhorstmann
Please check the implementation.
There is trouble with $pageInfo variable which is not defined.

Classes/FrontendEnvironment/Tsfe.php Outdated Show resolved Hide resolved
@timhorstmann
Copy link
Author

@dkd-kaehm Yes. Thank you for noticing. I updated the PR.

@timhorstmann
Copy link
Author

This does not work as aspected.
$pageRecord['uid'] is not present. If i fix this, the page is not removed from the index queue, but still can't be found. I will update the PR.

@timhorstmann
Copy link
Author

@dkd-kaehm We had a sideeffect with another issue with our customer. Took me a while to sort things out and have this tested from our test-team. I am confident that my PR is fine now.

I'm a little confused by the last comment. Is there another TODO for me?

@dkd-kaehm
Copy link
Collaborator

dkd-kaehm commented Mar 4, 2024

I'm a little confused by the last comment. Is there another TODO for me?

You mean following?:

Please check the implementation.
There is trouble with $pageInfo variable which is not defined.

If so, you answered and fixed it already.

@dkd-kaehm dkd-kaehm force-pushed the bugfix/issue-3566 branch from 2aa07ed to dc06225 Compare May 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Subpage of page with restricted access and extendToSubpages set is removed from index queue
2 participants