-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Issue #3566: Check rootline for feGroups from page with extendToSubpages set #3926
base: main
Are you sure you want to change the base?
Conversation
efdd578
to
914a659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timhorstmann
Please check the implementation.
There is trouble with $pageInfo
variable which is not defined.
8d8e73b
to
14c9e56
Compare
14c9e56
to
aa0cf85
Compare
@dkd-kaehm Yes. Thank you for noticing. I updated the PR. |
This does not work as aspected. |
aa0cf85
to
7654530
Compare
7654530
to
2aa07ed
Compare
@dkd-kaehm We had a sideeffect with another issue with our customer. Took me a while to sort things out and have this tested from our test-team. I am confident that my PR is fine now. I'm a little confused by the last comment. Is there another TODO for me? |
You mean following?:
If so, you answered and fixed it already. |
2aa07ed
to
dc06225
Compare
dc06225
to
1d6ae0e
Compare
363e234
to
a9bae2f
Compare
e865edc
to
89d9f0d
Compare
16bf8c5
to
dfcdd98
Compare
What this pr does
When fetching usergroups to build a TSFE, the fe_groups field from current page could be empty. But there might be a page in the rootline with feGroups and extendToSubpages set.
This PR collects the feGroups from the rootline in this case.
The code is inspired from TYPO3\CMS\Backend\Utility\BackendUtility::ADMCMD_previewCmds
How to test
See #3566
Fixes: #3566