Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issue in installation commands in documentation #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Unobtainiumrock
Copy link

What does this PR do?

This PR fixes a minor but significant issue in the documentation related to the installation of AdalFlow with specific dependencies. It corrects the syntax of pip install adalflow[open-ai, faiss-cpu] to adalflow[open-ai,faiss-cpu], removing the trailing whitespace that would cause an error during installation.

This change is critical because this section of the documentation is often copy-pasted directly by first-time users. Ensuring a smooth and error-free setup process is essential for creating a great first impression of the library and providing a frictionless onboarding experience.

Issue Number non-applicable


Breaking Changes:

This PR does not introduce any breaking changes.


Before submitting
  • Was this discussed/agreed via a GitHub issue?
    No, this was identified as a direct improvement during a review of the installation guide.

  • Did you read the contributor guideline?
    Yes.

  • Did you make sure your PR does only one thing, instead of bundling different changes together?
    Yes, this PR focuses solely on fixing the documentation syntax for installation instructions.

  • Did you make sure to update the documentation with your changes?
    Yes, the relevant section of the documentation was updated.

  • Did you write any new necessary tests?
    Not applicable for this documentation-only fix.

  • Did you verify new and existing tests pass locally with your changes?
    Not applicable for this documentation-only fix.

  • Did you list all the breaking changes introduced by this pull request?
    No breaking changes were introduced.


Additional Notes:

This change significantly impacts the first-time user experience, which is critical for adoption. Errors during the installation process can discourage potential users. By ensuring the installation instructions are accurate and error-free, we provide a smoother experience for newcomers to AdalFlow.


Had fun improving the documentation! 🙃


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant