Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5287 added notification #1072

Merged
merged 6 commits into from
Jan 15, 2025
Merged

BED-5287 added notification #1072

merged 6 commits into from
Jan 15, 2025

Conversation

Holocraft
Copy link
Contributor

@Holocraft Holocraft commented Jan 14, 2025

Description

A notification is needed when the user is redirected back to the login page when SSO login fails.

Motivation and Context

This PR addresses: [BED-5287](https://specterops.atlassian.net/browse/BED-5287)

Why is this change required? What problem does it solve?
This change enables the user to see an error notification for why the SSO login failed.

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

This was tested by forcing an error in the oidc.go file to send a query param with an error message. Clicking on the SSO login will trigger the error and the user will see the error notification on the bottom left of the screen.

Screenshots (optional):

error

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

cmd/ui/src/components/LoginPage.tsx Outdated Show resolved Hide resolved
cmd/ui/src/components/LoginPage.tsx Outdated Show resolved Hide resolved
@Holocraft Holocraft merged commit 6195e1b into main Jan 15, 2025
5 checks passed
@Holocraft Holocraft deleted the BED-5287 branch January 15, 2025 23:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants