Parameter box improvements #5119

yw4z · 2024-04-22T23:18:44Z

Adds missing / empty side texts

• Added "Layers" side text for

Top shell layers
Bottom shell layers
Number of slow layers

• Added "Layer" side text for

Full fan speed at layer

• Added "mm" side text for

Mesh margin
Minimum wall length

• Added "°C" side text for

Softening temperature

Fixes combo boxes without arrows

Support > Style

Filament Supports

Support > Advanced

after fix shows dropdown arrows if there is no icon for dropdown item

Converts double input boxes to regular input boxes

After Fix

• Used icons for X / Y instead text. input boxes aligns perfectly with other components
• Didn't use combined side text because it not matches style with other components
• Solves styling problem and gives same result on all platforms

Preview for Printer Settings > Printable Area > Set

before	after

Also matched style of Create printer window
• Used text align on left like on other components
• Matched width of input boxes with other components

before	after

Questionable areas for discussion (EXCLUDED FROM COMMIT)

• Converting these to spin boxes. Currently it combines combo box and input box and it has weird usage and no need to use on this ones because dropdown only shows numbers without any description. Using spin boxes better because other layer related input boxes uses this too

Top interface layers
Bottom interface layers

I noticed there is a "Same as Top" option for Bottom interface layers. I guess i will revert back to default with your comment

not rendered well with side text

solution with spin box. there is an explanation required on tooltip for -1 equals same as top

Also this ones combines combo box and input box. like i said its weird but helpful on this ones compared to interface layers ones

sparse_infill_line_width
infill_anchor_max
infill_anchor

If you planning to add more pre defined values for value boxes in future maybe increasing width of input boxes will be a good choice because value + dropdown arrow + side text looks very dense

I tried to make use them as regular input box in my UI commit but probably revert back with your comment

• Added "Layers" side text for Bottom shell layers Number of slow layers Top shell layers • Added "Layer" side text for Full fan speed at layer • Added "x" side text for ratios. This one looks nice imo Internal bridge flow ratio Bridge flow ratio Top surface flow ratio Bottom surface flow ratio Flow ratio Scarf joint flow ratio • Added "mm" side text for Mesh margin Minimum wall length • Added "°C" side text for Softening temperature • Converted these to spin boxes. Currently it combines combo box and input box and it has weird usage. Using spin boxes better because other layer related input boxes uses this too Top interface layers Bottom interface layers

discip · 2024-04-23T06:38:51Z

• Added "Layers" side text for

• Added "Layer" side text for

Regarding all the 'side texts', you should consider the context:

If the corresponding unit is used in the description in front of the value, there is no need to put it additionally thereafter.
• Added "mm" side text for

&

• Added "°C" side text for

👍
• Converted these to spin boxes ...
- Due to the mentioned reason in 1., no need for 'side texts' here as well.
- Since a drop-down allows you to access all the values more quickly without having to click through them individually, as would be the case using a spin box, please leave this as is.
I tried to make use them as regular input box in my UI commit but probably revert back with your comment

Please don't remove the arrow.

yw4z · 2024-04-23T11:23:16Z

@discip then we should delete these with your logic

side text generally uses units and its unit "Layer" / "Layers" in my perspective

problem is combining combo box and and input box and parameter value boxes too narrow to fit multiple components

about spin boxes you can set value faster with them compared to combo box

discip · 2024-04-23T19:38:40Z

then we should delete these with your logic

Absolutely! 😃👍
I haven't checked every other possible case, but since you're at it, it would be great if you maintained the tendency you've demonstrated to make everything as consistent as possible. 😊
side text generally uses units and its unit "Layer" / "Layers" in my perspective

To demonstrate what I mean:
Compared to e.g.: length, where you could have mm or cm, in which case it makes perfect sense to put the unit in the text box, even though the description contains the word length, the 'unit' layers doesn't need any further specification.
problem is combining combo box and and input box and parameter value boxes too narrow to fit multiple components

I'm having no issues using the current setup. 🤷🏻
about spin boxes you can set value faster with them compared to combo box
1. It depends on the amount of values the list contains.
2. In most cases you would need 2 clicks to get any value with a drop down opposed to a spin box.
  e.g.: If your current value is 1 you would need to click 4 times to get to the 5 with a spin box. With a drop down however, you click the arrow and 5 (2 clicks)!

I'm really curious about what others think about these changes.

yw4z · 2024-04-23T20:25:40Z

about spin boxes you can set value faster with them compared to combo box

It depends on the amount of values the list contains.

In most cases you would need 2 clicks to get any value with a drop down opposed to a spin box.
e.g.: If your current value is 1 you would need to click 4 times to get to the 5 with a spin box. With a drop down however, you click the arrow and 5 (2 clicks)!

you just count mouse clicks. you should also count mouse movements as steps

yw4z · 2024-04-30T12:51:54Z

@SoftFever this commit also ready for review. also there is a "Questionable areas for discussion" section on first post

yw4z · 2024-05-18T17:14:05Z

@SoftFever should i split this commit to separate commits
• Add missing side texts for parameter boxes
• Fix combo box arrows not appearing if there is no icon for drop down list item
• Convert double input boxes for points to regular input boxes
• Better color for disabled elements on dark mode (Will move this to new color fixes commit)
• Match text color of disabled combo box (Will move this to new color fixes commit)

SoftFever · 2024-05-24T12:18:05Z

src/libslic3r/PrintConfig.cpp

@@ -816,6 +816,7 @@ void PrintConfigDef::init_fff_params()
    def = this->add("bottom_shell_layers", coInt);
    def->label = L("Bottom shell layers");
    def->category = L("Strength");
+    def->sidetext = L("layers"); // ORCA add side text


This works really good 👍

SoftFever · 2024-05-24T12:18:36Z

src/libslic3r/PrintConfig.cpp

@@ -918,6 +919,7 @@ void PrintConfigDef::init_fff_params()
    def->category = L("Quality");
    def->tooltip = L("Decrease this value slightly(for example 0.9) to reduce the amount of material for bridge, "
                     "to improve sag");
+    def->sidetext = L("x"); // ORCA add side text


I find add "x" side text strange.
Can we remove x side texts?

there is a % used for percentage. x fits well for ratio imo. also i tried to show values as "1.00" to indicate its float numbers but they always rounded to "1"

% and other units like mm are common and therefore look natural.
The x looks very strange and confusing as it displays like 1 x.
We shouldn't add it.

google suggest few alternatives for multiplier symbol.
Multiplication sign definition: the symbol ( ⋅ ), ( × ), or ( ∗ )
But ratio is completely different thing. it mostly suggest proportional ratio and its symbol is " : "

1 mm 1 x 1 ⋅ 1 × 1 ∗

ofc i would not die if we dont add it. still looks nice imo :)

here is degree, mm, % and x in same view

I still think the x is confusing here :)

SoftFever · 2024-05-24T12:21:20Z

resources/images/inputbox_y.svg

Good one!
One suggestion though, can we make the font easier to read? the current square font may cause confusion IMO

yw4z · 2024-05-24T15:51:10Z

@SoftFever updated point control icons
before

after

SoftFever · 2024-05-28T14:38:47Z

@yw4z
What's the status of the PR?
Could we remove the x sidenote?

yw4z · 2024-05-28T14:47:33Z

@SoftFever yes i will remove them but quite busy atm. probably complete changes on PRs on end of week

yw4z · 2024-05-29T05:11:23Z

@SoftFever reverted changes for "x" side text and removed color related fixes because they need additional changes. i will send color related issues as another commit because i found 10+ more

btw why this one not uses percentages. it will make it easier to understand

SoftFever

LGTM

Fix for combo boxes without arrows

3c72b96

yw4z marked this pull request as draft April 27, 2024 14:41

yw4z added 12 commits April 27, 2024 18:50

Add icon files for Point input boxes

c47523a

Add side text for Point controls

91b4338

Update width of point controls

9518049

Use TextInput for PointCtrl

a528697

Use TextInput for PointCtrl

6e400b5

Update style of Point Control

89ba091

Merge branch 'main' into parameter-improvements

326e0e8

Better Background color for Disabled elements on dark mode

8567e8b

Use same color for disabled text on combo boxes

dfef541

Use Slightly darker text color for disabled text elements

4b1335f

Revert changes for Top / Bottom interface layers parameter boxes

bd6447c

Merge branch 'main' into parameter-improvements

f790be5

yw4z marked this pull request as ready for review April 30, 2024 10:05

yw4z added 2 commits May 18, 2024 18:26

Merge branch 'main' into parameter-improvements

ea9e9be

fix build error

5f9ffdf

Merge branch 'main' into parameter-improvements

31f0a7b

SoftFever reviewed May 24, 2024

View reviewed changes

yw4z added 2 commits May 24, 2024 17:14

Merge branch 'main' into parameter-improvements

53af349

update point control icons

87c9e7a

yw4z added 2 commits May 29, 2024 07:54

Remove "x" side text from flow ratio related parameters

af28c4c

revert color related fixes

0f3930d

yw4z added 2 commits May 29, 2024 08:13

Merge branch 'main' into parameter-improvements

76a7a52

Merge branch 'main' into parameter-improvements

f6e7714

SoftFever approved these changes May 29, 2024

View reviewed changes

SoftFever merged commit c14ae13 into SoftFever:main May 29, 2024
8 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parameter box improvements #5119

Parameter box improvements #5119

yw4z commented Apr 22, 2024 •

edited

Loading

discip commented Apr 23, 2024

👍

yw4z commented Apr 23, 2024 •

edited

Loading

discip commented Apr 23, 2024

yw4z commented Apr 23, 2024

yw4z commented Apr 30, 2024

yw4z commented May 18, 2024

SoftFever May 24, 2024

SoftFever May 24, 2024

yw4z May 24, 2024

SoftFever May 25, 2024

yw4z May 25, 2024

SoftFever May 25, 2024

SoftFever May 24, 2024

yw4z commented May 24, 2024

SoftFever commented May 28, 2024

yw4z commented May 28, 2024

yw4z commented May 29, 2024 •

edited

Loading

SoftFever left a comment

Parameter box improvements #5119

Parameter box improvements #5119

Conversation

yw4z commented Apr 22, 2024 • edited Loading

Adds missing / empty side texts

Fixes combo boxes without arrows

Converts double input boxes to regular input boxes

Questionable areas for discussion (EXCLUDED FROM COMMIT)

discip commented Apr 23, 2024

👍

yw4z commented Apr 23, 2024 • edited Loading

discip commented Apr 23, 2024

yw4z commented Apr 23, 2024

yw4z commented Apr 30, 2024

yw4z commented May 18, 2024

SoftFever May 24, 2024

Choose a reason for hiding this comment

SoftFever May 24, 2024

Choose a reason for hiding this comment

yw4z May 24, 2024

Choose a reason for hiding this comment

SoftFever May 25, 2024

Choose a reason for hiding this comment

yw4z May 25, 2024

Choose a reason for hiding this comment

SoftFever May 25, 2024

Choose a reason for hiding this comment

SoftFever May 24, 2024

Choose a reason for hiding this comment

yw4z commented May 24, 2024

SoftFever commented May 28, 2024

yw4z commented May 28, 2024

yw4z commented May 29, 2024 • edited Loading

SoftFever left a comment

Choose a reason for hiding this comment

yw4z commented Apr 22, 2024 •

edited

Loading

yw4z commented Apr 23, 2024 •

edited

Loading

yw4z commented May 29, 2024 •

edited

Loading