Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu_features improvements #2092

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

metalefty
Copy link
Contributor

Changes proposed in this pull request:

  • Update bundled cpu_features to 0.9.0
  • Allow the use of cpu_features for more architectures (aarch64, s390x, etc) on Linux [1]
  • Add USE_SYSTEM_CPU_FEATURES flag to use system's cpu_features instead of the bundled one
  • Use system's cpu_features in FreeBSD CI (for the proof of USE_SYSTEM_CPU_FEATURES)

[1] https://github.com/google/cpu_features/tree/v0.9.0?tab=readme-ov-file#whats-supported

- Add USE_SYSTEM_CPU_FEATURES flag to use system's cpu_features
  instead of the bundled one
- Allow the use of cpu_features for more architectures on Linux [1]

[1] https://github.com/google/cpu_features/tree/v0.9.0?tab=readme-ov-file#whats-supported
@metalefty
Copy link
Contributor Author

I'll fix the rawhide CI failure.

@chipitsine
Copy link
Member

btw, I'm not a big fan of git modules.
as we can pick it from system, i.e. USE_SYSTEM_CPU_FEATURES, can we use it as only approach ? or do we miss it on Windows ?

@chipitsine
Copy link
Member

I'll fix the rawhide CI failure.

I'd suggest to switch to USE_SYSTEM_CPU_FEATURES where possible

@metalefty
Copy link
Contributor Author

I made this change not to change the current structure and behaviour too much. However, I personally like to switch to the system cpu_features, like libsodium, rather than this approach. I'll raise another PR, let me some time.

I'm not sure about Windows BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants