Add Github action to set up snowcli in a CI/CD workflow #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jvasquezrojas
force-pushed
the
composite_snowcli_action_deploy
branch
from
8dd0dfb to
28fd622
Compare
sfc-gh-jvasquezrojas
force-pushed
the
composite_snowcli_action_deploy
branch
from
367f9ec to
5d5b423
Compare
| cli-version: | ||
| description: 'Snowflake CLI version' | ||
| required: false | ||
| default: '' |
There was a problem hiding this comment.
I'm wondering if "latest" would be more meaningful, what do you think? It would add more information about what is the default behavior without checking scripts
Add environment variable for the snowflake account
…install_snowcli.sh
- Split test into different files - Add comment that specify why we add a new directory to the PATH variable - Add comment explaining the workaround
sfc-gh-jvasquezrojas
force-pushed
the
composite_snowcli_action_deploy
branch
from
5d5b423 to
a5020fc
Compare
sfc-gh-jvasquezrojas
requested a review
from sfc-gh-jmoralescarmiol
as a code owner
sfc-gh-turbaszek
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action installs snowflake-cli-labs in an isolated environment using pipx, so it will not have conflicts with any other package. In addition there is an optional parameter to set up a default config file in .snowflake directory.
There is not a conventional way to test a composite github action because there is not a framework for that, instead some
usage examples were added to ensure a valid correctness and utility of the github action. A brief description of every example jobs and what they do are the following:
install_Snowcli_with_pip_and_then_with_pipx: This job installs snowcli version 2.1.0 with pipx and version 2.1.1 with pip, the workflow should show 2.1.0 when executes snow --version.
install_in_multiple_os: This job validates the correct installation of snowcli in any OS.
deploy_demo_native_app: This is a more complex that set up snowflake cli and creates a version for the applicaiton package defined in the source code.