Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #113

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Add CI #113

merged 2 commits into from
Dec 31, 2024

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Dec 31, 2024 •
edited
Loading

  • Bumps MW requirements to 1.39+.
  • Requires PHP 7.4+
  • Adds CI to run tests
  • Fixes tests to support MW 1.39
  • Adapts to changes done to the naming of files.

@paladox paladox force-pushed the add-ci branch 5 times, most recently from fd0f9da to f35ea56 Compare December 31, 2024 13:31
@JeroenDeDauw
Copy link
Member

Looks good so far, though it gets a bit more difficult to review due to the PR containing a bunch of unrelated changes. I'm mentioning it for future PRs and am not requesting you change this one.

@paladox paladox force-pushed the add-ci branch 11 times, most recently from d2a316f to 9b947bb Compare December 31, 2024 14:53
@paladox
Copy link
Contributor Author

paladox commented Dec 31, 2024

Coverage and MW 1.40+ ci will be added separately. For now the tests are now working!!

@paladox paladox requested a review from JeroenDeDauw December 31, 2024 14:56
@paladox
Add CI
d3d8bea 
* Bumps MW requirements to 1.39+.
* Requires PHP 7.4+
* Adds CI to run tests
* Fixes tests to support MW 1.39
* Adapts to changes done to the naming of files.
JeroenDeDauw
JeroenDeDauw reviewed Dec 31, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
JeroenDeDauw
JeroenDeDauw reviewed Dec 31, 2024
View reviewed changes
.github/workflows/ci.yml

- name: Run tests
run: make ci
if: matrix.coverage == false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specific to this PR, but I noticed that the "Run tests" task output if 90%+ setup noise. So it if you open up the output on GitHub actions, you have to do a lot of scrolling. Ideally setup is done in a dedicated step.

@gesinn-it-gea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/SemanticMediaWiki/SemanticWatchlist/actions/runs/12561101773/job/35019462246

@JeroenDeDauw JeroenDeDauw merged commit 26a5b68 into master Dec 31, 2024
1 check passed
@JeroenDeDauw JeroenDeDauw deleted the add-ci branch December 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeroenDeDauw JeroenDeDauw JeroenDeDauw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paladox @JeroenDeDauw